Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
b561638 to
f4f38e8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8222 +/- ##
==========================================
- Coverage 73.57% 73.57% -0.01%
==========================================
Files 242 242
Lines 37000 37004 +4
==========================================
+ Hits 27224 27225 +1
- Misses 7854 7856 +2
- Partials 1922 1923 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4273702 to
a927176
Compare
3311249 to
4e6b6cd
Compare
internal/xds/translator/testdata/out/xds-ir/xds-name-scheme-v2.clusters.yaml
Outdated
Show resolved
Hide resolved
|
what will be the cluster name for the non backend filter case when there are N backendRefs |
change from |
9a084da to
661283f
Compare
661283f to
dd1b4d8
Compare
|
what does the |
Nothing If need N clusters, you will got |
| kind: HTTPRoute | ||
| name: httproute-1 | ||
| namespace: default | ||
| name: httproute/default/httproute-1/rule/0/backend/0 |
There was a problem hiding this comment.
@arkodg this's the line which changed from httproute/default/httproute-1/rule/0
can you elaborate what xDS resources will be needed
today, for this case, we dont use any weighted cluster for this case for this case |
yeah, today you will have a cluster named
With this patch, |
-1 on special naming only for 0th index the field name here impacts
and this will add unnecessary complexity and cognitive load for users |
4838bd7 to
7a718fc
Compare
I understand this's an edge case, could we do something to reduce the noise? what about add a runtime flag for this? |
This's a little tricky, but will fix #6287.
This patch change the cluster naming to make the cluster name be same w/wo backend filters.